[ 
https://issues.apache.org/jira/browse/HDFS-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550370#comment-15550370
 ] 

Wei-Chiu Chuang commented on HDFS-10683:
----------------------------------------

+1

> Make class Token$PrivateToken private
> -------------------------------------
>
>                 Key: HDFS-10683
>                 URL: https://issues.apache.org/jira/browse/HDFS-10683
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.9.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>              Labels: fs, ha, security, security_token
>         Attachments: HDFS-10683.001.patch, HDFS-10683.002.patch
>
>
> Avoid {{instanceof}} or typecasting of {{Toke.PrivateToken}} by introducing 
> an interface method in {{Token}}. Make class {{Toke.PrivateToken}} private. 
> Use a factory method instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to