[
https://issues.apache.org/jira/browse/HDFS-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551236#comment-15551236
]
Takanobu Asanuma commented on HDFS-10933:
-----------------------------------------
I uploaded initial patches based on [~jojochuang]'s advice in HDFS-10826.
- make a common variable of {{MiniDFSCluster}} and use @After annotation to
shutdown it.
- remove all {{FileSystem.close}} since {{MiniDFSCluster.shutdown}} closes
{{FileSystem}}.
- remove unnecessary try statements.
- use LogFactory instead of using FSImage.LOG.
{{HDFS-10933.WIP.1.patch}} doesn't arrange indents so that it is easy to be
reviewed. {{HDFS-10933.1.patch}} fixes them on top of the WIP patch.
Please review it when you are fee. Thanks!
> Refactor TestFsck
> -----------------
>
> Key: HDFS-10933
> URL: https://issues.apache.org/jira/browse/HDFS-10933
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Minor
> Attachments: HDFS-10933.1.patch, HDFS-10933.WIP.1.patch
>
>
> {{TestFsck}} should be refactored.
> - use @Before @After annotations
> - improve loggings
> - fix checkstyle warnings
> etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
