[
https://issues.apache.org/jira/browse/HDFS-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766123#comment-15766123
]
Takanobu Asanuma commented on HDFS-11121:
-----------------------------------------
Sorry for late reply and thank you for your kind review, [~jojochuang].
bq. I wonder if we can add a similar isStripedBlockId assertion in
BlockInfoStriped constructor.
It seems some unit tests don't have the assumption that a striped blockId is
always a negative number (please see TestStripedINodeFile.java). Should we
unify all source code with the assumption?
> Add assertions to BlockInfo#addStorage to protect from breaking
> reportedBlock-blockGroup mapping
> ------------------------------------------------------------------------------------------------
>
> Key: HDFS-11121
> URL: https://issues.apache.org/jira/browse/HDFS-11121
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
> Affects Versions: 3.0.0-alpha1
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Critical
> Fix For: 3.0.0-alpha2
>
> Attachments: HDFS-11121.1.patch
>
>
> There are not any assertions in {{BlockInfo.addStorage}}. This may cause that
> {{BlockInfo}} instances accept strange block reports and result in serious
> bugs, like HDFS-10858.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
