[ https://issues.apache.org/jira/browse/HDFS-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822304#comment-15822304 ]
Wei-Chiu Chuang commented on HDFS-11121: ---------------------------------------- Thanks for the patch. LGTM for most part. I just have a small question: asserts are only enabled if JVM runs with -ea parameter, which is typically not the case for production cluster. Is this what you intend to do? Or should we switch to Precondition.checkArgument() instead? > Add assertions to BlockInfo#addStorage to protect from breaking > reportedBlock-blockGroup mapping > ------------------------------------------------------------------------------------------------ > > Key: HDFS-11121 > URL: https://issues.apache.org/jira/browse/HDFS-11121 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding > Affects Versions: 3.0.0-alpha1 > Reporter: Takanobu Asanuma > Assignee: Takanobu Asanuma > Priority: Critical > Labels: hdfs-ec-3.0-nice-to-have > Fix For: 3.0.0-alpha2 > > Attachments: HDFS-11121.1.patch, HDFS-11121.2.patch > > > There are not any assertions in {{BlockInfo.addStorage}}. This may cause that > {{BlockInfo}} instances accept strange block reports and result in serious > bugs, like HDFS-10858. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org