[ https://issues.apache.org/jira/browse/HDFS-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027963#comment-13027963 ]
Hadoop QA commented on HDFS-1850: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478000/hdfs-1850-7.patch against trunk revision 1098781. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 38 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/444//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/444//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/444//console This message is automatically generated. > DN should transmit absolute failed volume count rather than increments to the > NN > -------------------------------------------------------------------------------- > > Key: HDFS-1850 > URL: https://issues.apache.org/jira/browse/HDFS-1850 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, name-node > Reporter: Eli Collins > Assignee: Eli Collins > Fix For: 0.22.0 > > Attachments: hdfs-1850-1.patch, hdfs-1850-2.patch, hdfs-1850-3.patch, > hdfs-1850-4.patch, hdfs-1850-5.patch, hdfs-1850-6.patch, hdfs-1850-7.patch > > > The API added in HDFS-811 for the DN to report volume failures to the NN is > "inc(DN)". However the given sequence of events will result in the NN > forgetting about reported failed volumes: > # DN loses a volume and reports it > # NN restarts > # DN re-registers to the new NN > A more robust interface would be to have the DN report the total number of > volume failures to the NN each heart beat (the same way other volume state is > transmitted). > This will likely be an incompatible change since it requires changing the > Datanode protocol. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira