[
https://issues.apache.org/jira/browse/HDFS-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806030#comment-15806030
]
Dilaver commented on HDFS-11259:
--------------------------------
Thanks for the change Manoj. LGTM.
Some nits around test polling and timeouts:
{quote}
{code}
+ do {
+ Thread.sleep(2000);
+ for (DatanodeInfo info : dfs.getDataNodeStats()) {
+ if (dnName.equals(info.getXferAddr())) {
+ datanodeInfo = info;
+ }
+ }
+ } while (datanodeInfo != null && !datanodeInfo.isInMaintenance());
{code}
{quote}
- please check if something like {{GenericTestUtils#waitFor}} can be used where
the state is being polled, or if refactoring them into something like
"waitForInMaintenance" makes sense
- consider sleeping less than 2sec while polling
- also consider adding timeouts to test cases
> Update fsck to display maintenance state info
> ---------------------------------------------
>
> Key: HDFS-11259
> URL: https://issues.apache.org/jira/browse/HDFS-11259
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 3.0.0-alpha1
> Reporter: Manoj Govindassamy
> Assignee: Manoj Govindassamy
> Attachments: HDFS-11259.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
