[ https://issues.apache.org/jira/browse/HDFS-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829263#comment-15829263 ]
Lei (Eddy) Xu commented on HDFS-11259: -------------------------------------- Hi, [~manojg]. LGTM overall. One small nit: You might want to consider to change "-includeMaintenanceState" to "-maintenance", to be consistent with the rest of flags, which are nouns. You might also want to provide a tests without "-maintenance" flag in fsck, and verify that the outputs do not contain maintenance state. {code} assertTrue(!fsckOut.contains("(ENTERING MAINTENANCE)")); assertTrue(!fsckOut.contains("(IN MAINTENANCE)")); {code} {{assertFalse}}? Thanks! > Update fsck to display maintenance state info > --------------------------------------------- > > Key: HDFS-11259 > URL: https://issues.apache.org/jira/browse/HDFS-11259 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Affects Versions: 3.0.0-alpha1 > Reporter: Manoj Govindassamy > Assignee: Manoj Govindassamy > Attachments: HDFS-11259.01.patch, HDFS-11259.02.patch, > HDFS-11259.03.patch, HDFS-11259-branch-2.01.patch, > HDFS-11259-branch-2.02.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org