[
https://issues.apache.org/jira/browse/HDFS-11163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889838#comment-15889838
]
Vinayakumar B commented on HDFS-11163:
--------------------------------------
Updated looks good.
Have few comments.
1. {code}+ public static final byte DEFAULT_STORAGE_POLICY_ID = 7;{code}
For Non-HDFS FileSystems let the default value be 0 itself. Current default
value of 7 is defined in HDFS' BlockStoragePolicySuite, this is anyway taken
for FsServerDefaults in FSNameSystem.
So, I think no need of Constant {{DEFAULT_STORAGE_POLICY_ID = 7}} in
CommonConfigurationsKeys. Default instance of FsServerDefaults can have 0 as
the value. Let 7 be taken from FSNameSystem for HDFS specific implementation.
2. {{FsServerDefaulls#getDefaultStoragePolicy}} rename to
{{FsServerDefaults#getDefaultStoragePolicyId()}}. Similarly {{storagepolicy}}
to {{storagepolicyId}}
3. In Hdfs.proto {{+ optional uint32 policyId = 9 [default = 7];}} also can
return 0 as default value.
+1 once above comments addressed.
> Mover should move the file blocks to default storage once policy is unset
> -------------------------------------------------------------------------
>
> Key: HDFS-11163
> URL: https://issues.apache.org/jira/browse/HDFS-11163
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer & mover
> Affects Versions: 2.8.0
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-11163-001.patch, HDFS-11163-002.patch,
> HDFS-11163-003.patch
>
>
> HDFS-9534 added new API in FileSystem to unset the storage policy. Once
> policy is unset blocks should move back to the default storage policy.
> Currently mover is not moving file blocks which have zero storage ID
> {code}
> // currently we ignore files with unspecified storage policy
> if (policyId == HdfsConstants.BLOCK_STORAGE_POLICY_ID_UNSPECIFIED) {
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
