[ https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895839#comment-15895839 ]
Nandakumar commented on HDFS-11395: ----------------------------------- Thanks for the review [~jingzhao]. The following review comments are incorporated in the latest patch: [^HDFS-11395.003.patch] * Renaming of "exception" to "failException" * Assigning value to "failException" field only when the action is FAIL * Unwrapping of exception in {{RequestHedgingProxyProvider#RequestHedgingInvocationHandler#invoke}}, for all kinds of exception * Unit test case added to cover ConnectException/EOFException * Fixed indentation, line length in test cases Please review the new patch. > RequestHedgingProxyProvider#RequestHedgingInvocationHandler hides the > Exception thrown from NameNode > ---------------------------------------------------------------------------------------------------- > > Key: HDFS-11395 > URL: https://issues.apache.org/jira/browse/HDFS-11395 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha > Reporter: Nandakumar > Assignee: Nandakumar > Attachments: HDFS-11395.000.patch, HDFS-11395.001.patch, > HDFS-11395.002.patch, HDFS-11395.003.patch > > > When using RequestHedgingProxyProvider, in case of Exception (like > FileNotFoundException) from ActiveNameNode, > {{RequestHedgingProxyProvider#RequestHedgingInvocationHandler.invoke}} > receives {{ExecutionException}} since we use {{CompletionService}} for the > call. The ExecutionException is put into a map and wrapped with > {{MultiException}}. > So for a FileNotFoundException the client receives > {{MultiException(Map(ExecutionException(InvocationTargetException(RemoteException(FileNotFoundException)))))}} > It will cause problem in clients which are handling RemoteExceptions. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org