[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897830#comment-15897830
]
Jing Zhao commented on HDFS-11395:
----------------------------------
The 004 patch looks good to me. Just some minors:
# Here since we're sure e is a MultiException, we can directly catch
"MultiException e".
{code}
380 } catch (Exception e) {
381 for (Exception ex : ((MultiException)e).getExceptions().values())
{
{code}
# The following code can be simplified as "Assert.assertTrue("......", rEx
instanceof StandbyException)"
{code}
if (rEx instanceof StandbyException) {
continue;
} else {
Assert.fail("Unexpected RemoteException: " + rEx.getMessage());
}
{code}
# "@param ex" can be removed.
{code}
* @param ex
* @return unwrapped exception
*/
private Exception unwrapException(Exception ex) {
{code}
> RequestHedgingProxyProvider#RequestHedgingInvocationHandler hides the
> Exception thrown from NameNode
> ----------------------------------------------------------------------------------------------------
>
> Key: HDFS-11395
> URL: https://issues.apache.org/jira/browse/HDFS-11395
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
> Reporter: Nandakumar
> Assignee: Nandakumar
> Attachments: HDFS-11395.000.patch, HDFS-11395.001.patch,
> HDFS-11395.002.patch, HDFS-11395.003.patch, HDFS-11395.004.patch
>
>
> When using RequestHedgingProxyProvider, in case of Exception (like
> FileNotFoundException) from ActiveNameNode,
> {{RequestHedgingProxyProvider#RequestHedgingInvocationHandler.invoke}}
> receives {{ExecutionException}} since we use {{CompletionService}} for the
> call. The ExecutionException is put into a map and wrapped with
> {{MultiException}}.
> So for a FileNotFoundException the client receives
> {{MultiException(Map(ExecutionException(InvocationTargetException(RemoteException(FileNotFoundException)))))}}
> It will cause problem in clients which are handling RemoteExceptions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
