[ https://issues.apache.org/jira/browse/HDFS-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898412#comment-15898412 ]
Chen Liang commented on HDFS-11482: ----------------------------------- I was looking into what would happen when chooseRandom and add/remove are being called simultaneously. I'm inclined to believe that as long as the {{DFSNetworkTopology}} object is synchronized by the caller when calling chooseRandom and add/remove, there should be no problem. But any comments are more than welcome. > Add storage type demand to into DFSNetworkTopology#chooseRandom > --------------------------------------------------------------- > > Key: HDFS-11482 > URL: https://issues.apache.org/jira/browse/HDFS-11482 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Chen Liang > Assignee: Chen Liang > Attachments: HDFS-11482.001.patch, HDFS-11482.002.patch > > > HDFS-11450 adds storage type info into network topology, with on this info we > may change chooseRandom to take storage type requirement as parameter, only > checking subtrees required storage type available. This way we avoid blindly > picking up nodes that are not applicable. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org