[ 
https://issues.apache.org/jira/browse/HDFS-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904051#comment-15904051
 ] 

Arpit Agarwal commented on HDFS-11482:
--------------------------------------

The v7 patch is looking good. We can remove the unused method 
DFSTopologyNodeImpl#getStorageCount.

+1 with that addressed.

> Add storage type demand to into DFSNetworkTopology#chooseRandom
> ---------------------------------------------------------------
>
>                 Key: HDFS-11482
>                 URL: https://issues.apache.org/jira/browse/HDFS-11482
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>         Attachments: HDFS-11482.001.patch, HDFS-11482.002.patch, 
> HDFS-11482.003.patch, HDFS-11482.004.patch, HDFS-11482.005.patch, 
> HDFS-11482.006.patch, HDFS-11482.007.patch
>
>
> HDFS-11450 adds storage type info into network topology, with on this info we 
> may change chooseRandom to take storage type requirement as parameter, only 
> checking subtrees required storage type available. This way we avoid blindly 
> picking up nodes that are not applicable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to