[
https://issues.apache.org/jira/browse/HDFS-11769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007342#comment-16007342
]
Anu Engineer commented on HDFS-11769:
-------------------------------------
[~msingh] Thanks for uploading the patch. Overall it looks excellent. I have
some very minor comments.
_KeySpaceManagerProtocolClientSideTranslatorPB.java_
# resp = rpcProxy.createVolume(NULL_RPC_CONTROLLER,
req.build());
-- resp has a status field and if it is not OK, we should throw.
_ObjectStoreHandler.java_
# Not really part of this change, but in one of our earlier patches
we stopped using this string -- distributed.
{{if ("distributed".equalsIgnoreCase(shType))}}
_VolumeManager.java#VolumeManager_
# File ksmDBFile = new File(ksmDBPath, KSM_DB_NAME);
-- Should create this path if this does not exist ?
# {{options.createIfMissing(true);}} -- we don't need this since this is the
default option for levelDB.
_VolumeManager.java#createVolume_
# {{throw new IOException("Too many volumes for user:" + dbUserName);}}
dbUserName --> args.getOwnerName()
_DistributedStorageHandler.java_
# Thanks for fixing the comment in line 78. I think we should add a new param
instead of modifying the StorageContainerLocationProtocol param.
> Ozone: KSM: Add createVolume API
> --------------------------------
>
> Key: HDFS-11769
> URL: https://issues.apache.org/jira/browse/HDFS-11769
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Mukul Kumar Singh
> Attachments: HDFS-11769-HDFS-7240.001.patch
>
>
> Add createVolume API in KSM.
> createVolume API allows administrators to create a volume. The arguments to
> the API are:
> * Admin Name - The name of the administrator who is creating this volume.
> Volumes can be created only by administrators.
> * User Name - The name of the owner of this volume.
> * Quota - Quota information for this volume.
> This JIRA proposes to add the protobuf layer for createVolume and handling in
> KSM. We will file a followup JIRA for the KSM client.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
