[ https://issues.apache.org/jira/browse/HDFS-11769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009756#comment-16009756 ]
Xiaoyu Yao commented on HDFS-11769: ----------------------------------- Thanks [~msingh] for updating the patch. The latest patch looks pretty good to me. Just a few more minor issues: TestQuotaByStorageType.java This change is not related. We can fix the usage of this deprecated APIs outside ozone in a separate Apache JIRA on trunk. LevelDBStore.java Line 174: can we use the flyweight pattern for the sync option used by put/commit to avoid creating small objects per write? This can be moved to a class member that instantiate only once and used for all the writes. {code} this.syncOption = new WriteOptions(); syncOption.sync(true); {code} VolumeManager.java VolumeManager interface is to improve the testability of individual components (Volume/Bucket/Key) without depending on the actual implementation, e.g., test mocked KeyManager with a KeyManagerImpl using mocked VolumeManager/BuckManager that simply assumes the Volume/Bucket exists. MiniOzoneCluster.java We need to ensure KSM is shutdown in MiniOzoneCluster#shutdown() to avoid leaking. TestDistributedOzoneVolumes.java Line 57: I see we are using "distributed" for ozone handler type in line 74. Should we update the comment to differentiate TestLocalOzoneVolumes.java? Line 120: assert the getNumVolumeCreateFails=1 TestLocalOzoneVolumes.java Line 52-54: Are these the default configurations of MiniOzone cluster. If yes, we can remove this comments as they are not being changed by the tests. > Ozone: KSM: Add createVolume API > -------------------------------- > > Key: HDFS-11769 > URL: https://issues.apache.org/jira/browse/HDFS-11769 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Affects Versions: HDFS-7240 > Reporter: Anu Engineer > Assignee: Mukul Kumar Singh > Attachments: HDFS-11769-HDFS-7240.001.patch, > HDFS-11769-HDFS-7240.002.patch, HDFS-11769-HDFS-7240.003.patch, > HDFS-11769-HDFS-7240.004.patch, HDFS-11769-HDFS-7240.005.patch > > > Add createVolume API in KSM. > createVolume API allows administrators to create a volume. The arguments to > the API are: > * Admin Name - The name of the administrator who is creating this volume. > Volumes can be created only by administrators. > * User Name - The name of the owner of this volume. > * Quota - Quota information for this volume. > This JIRA proposes to add the protobuf layer for createVolume and handling in > KSM. We will file a followup JIRA for the KSM client. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org