[ 
https://issues.apache.org/jira/browse/HDFS-11769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010997#comment-16010997
 ] 

Xiaoyu Yao commented on HDFS-11769:
-----------------------------------

Thanks [~msingh] for the update. The patch looks excellent to me. Just a few 
more NITs, +1 after that being fixed.

KeySpaceManager.java
Line 63: this should be {{ private final VolumeManager volumeManager;}}

MiniOzoneCluster.java
Line 141-143 should be moved before line 137. We also need to check (ksm != 
null) just in case.

A few more checkstyle issues that seems fixable. 


> Ozone: KSM: Add createVolume API
> --------------------------------
>
>                 Key: HDFS-11769
>                 URL: https://issues.apache.org/jira/browse/HDFS-11769
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Mukul Kumar Singh
>         Attachments: HDFS-11769-HDFS-7240.001.patch, 
> HDFS-11769-HDFS-7240.002.patch, HDFS-11769-HDFS-7240.003.patch, 
> HDFS-11769-HDFS-7240.004.patch, HDFS-11769-HDFS-7240.005.patch, 
> HDFS-11769-HDFS-7240.006.patch, HDFS-11769-HDFS-7240.007.patch
>
>
> Add createVolume API in KSM.
> createVolume API allows administrators to create a volume. The arguments to 
> the API are:
> * Admin Name - The name of the administrator who is creating this volume. 
> Volumes can be created only by administrators.
> *  User Name - The name of the owner of this volume.
> * Quota - Quota information for this volume.
> This JIRA proposes to add the protobuf layer for createVolume and handling in 
> KSM. We will file a followup JIRA for the KSM client.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to