[ 
https://issues.apache.org/jira/browse/HDFS-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014265#comment-16014265
 ] 

Mukul Kumar Singh commented on HDFS-11775:
------------------------------------------

Thanks for the patch [~nandakumar131], Here are some of the early comments

1) please rename KeyspaceManagerProtocol.java to KeySpaceManagerProtocol.java, 
this results in compilation failure
2) BucketManagerImpl:35 - define DELIMITER in OzoneConsts.java
3) BucketManagerImpl:88 - please rename the comment
4) DistributedStorageHandler:187 - build is already being called in 188
5) OzoneAcl.java, please add comments to this new function
6) TestBucketManagerImpl.java is missing the licensing  

> Ozone: KSM : add createBucket 
> ------------------------------
>
>                 Key: HDFS-11775
>                 URL: https://issues.apache.org/jira/browse/HDFS-11775
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Nandakumar
>         Attachments: HDFS-11775-HDFS-7240.000.patch, 
> HDFS-11775-HDFS-7240.001.patch, HDFS-11775-HDFS-7240.002.patch, 
> HDFS-11775-HDFS-7240.003.patch, HDFS-11775-HDFS-7240.004.patch
>
>
> Creates a bucket if it does not exist. A precondition to creating a bucket is 
> that a parent volume must exist.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to