[ https://issues.apache.org/jira/browse/HDFS-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030569#comment-16030569 ]
John Zhuge commented on HDFS-11898: ----------------------------------- [~vinayrpet] For HDFS-11900, I decided to keep the pool static and submitted a simple patch for option #1 because it was the original design decision. It'd require careful design and review from original developer and reviewers to reverse the course. It will take a while. In your patch, I think {{DFSClient#isHedgedReadsEnabled}} can be simplified to just {{return hedgedReadEnabled;}}. {{initThreadsNumForHedgedReads}} guarantees HEDGED_READ_THREAD_POOL is not null and getMaximumPoolSize() > 0. > DFSClient#isHedgedReadsEnabled() should be per client flag > ----------------------------------------------------------- > > Key: HDFS-11898 > URL: https://issues.apache.org/jira/browse/HDFS-11898 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client > Reporter: Vinayakumar B > Assignee: Vinayakumar B > Attachments: HDFS-11898-01.patch > > > DFSClient#isHedgedReadsEnabled() returns value based on static > {{HEDGED_READ_THREAD_POOL}}. > Hence if any of the client initialized this in JVM, all remaining client > reads will be going through hedged read itself. > This flag should be per client value. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org