[
https://issues.apache.org/jira/browse/HDFS-11916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048372#comment-16048372
]
Lei (Eddy) Xu commented on HDFS-11916:
--------------------------------------
Hey, [~tasanuma0829] Thanks a lot for the patch.
Could you help to clarify the purpose of this test? My understanding is that
using a random policy for each time, it might cause flaky tests. For example,
one implementation of EC policy has bug, but it is hard to reproduce in the
following jenkins run?
Some small nits:
{code}
private static ErasureCodingPolicy ecPolicy;
{code}
Maybe we can just not use {{static}} here?
{code}
public TestErasureCodingPoliciesWithRandomECPolicy() {
ecPolicy = StripedFileTestUtil.getRandomNonDefaultECPolicy();
LOG.info(ecPolicy);
}
{code}
Could you add more context into the {{LOG.info()}}.
> Extend TestErasureCodingPolicies/TestErasureCodingPolicyWithSnapshot with a
> random EC policy
> --------------------------------------------------------------------------------------------
>
> Key: HDFS-11916
> URL: https://issues.apache.org/jira/browse/HDFS-11916
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding, test
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Labels: hdfs-ec-3.0-nice-to-have
> Attachments: HDFS-11916.1.patch, HDFS-11916.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
