[
https://issues.apache.org/jira/browse/HDFS-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054754#comment-16054754
]
Anu Engineer commented on HDFS-11997:
-------------------------------------
As an API for chunk calls, isn't it better to have these in the API ?.
This particular implementation of containers is not using it. But many others
might find it useful. If it is just part of signature, I don't know if it is
causing any issue.
> ChunkManager functions do not use the argument keyName
> ------------------------------------------------------
>
> Key: HDFS-11997
> URL: https://issues.apache.org/jira/browse/HDFS-11997
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
>
> {{ChunkManagerImpl}}'s functions i.e. {{writeChunk}} {{readChunk}}
> {{deleteChunk}} all take a {{keyName}} argument, which is not being used by
> any of them.
> I think this makes sense because conceptually {{ChunkManager}} should not
> have to know keyName to do anything, probably except for some sort of sanity
> check or logging, which is not there either. We should revisit whether we
> need it here. I think we should remove it to make the Chunk syntax, and the
> function signatures more cleanly abstracted.
> Any comments? [~anu]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
