[
https://issues.apache.org/jira/browse/HDFS-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054779#comment-16054779
]
Chen Liang commented on HDFS-11997:
-----------------------------------
I think from the perspective of abstraction, {{ChunkManager}} should work
(read/write/delete a chunk) given just the metadata of the chunk. This is not
causing any issue for now and will more likely never, but I felt having this
field but not being used causes confusions. I simply didn't see any cases where
this field should be used by ChunkManager as part of any of the operations. In
fact, an implementation of chunk manager that relies on key name seems breaking
the abstraction in some way to me...
> ChunkManager functions do not use the argument keyName
> ------------------------------------------------------
>
> Key: HDFS-11997
> URL: https://issues.apache.org/jira/browse/HDFS-11997
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
>
> {{ChunkManagerImpl}}'s functions i.e. {{writeChunk}} {{readChunk}}
> {{deleteChunk}} all take a {{keyName}} argument, which is not being used by
> any of them.
> I think this makes sense because conceptually {{ChunkManager}} should not
> have to know keyName to do anything, probably except for some sort of sanity
> check or logging, which is not there either. We should revisit whether we
> need it here. I think we should remove it to make the Chunk syntax, and the
> function signatures more cleanly abstracted.
> Any comments? [~anu]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
