[
https://issues.apache.org/jira/browse/HDFS-12118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084435#comment-16084435
]
Chen Liang commented on HDFS-12118:
-----------------------------------
Thanks [~linyiqun] for updating the patch and filing the JIRAs!
Some comments about v002 patch though:
1. seems the volume list check is added for only one place in
{{testListVolumes}}, can we add it for all non-error condition places?
2. using {{.stream()}} makes sense but I don't think {{.filter(item ->
item.startsWith("test-vol1")).collect(Collectors.toList());}} will do anything
here. I think what it does is it will keep all elements that has prefix
"test-vol1" and return as a list. Even if there is, say, zero of such elements,
it still just returns the list, no error/exception will happen whatsoever. So
this line won't help check anything. Maybe consider checking the length of the
returned list, it should be equal to size of original list (i.e. all elements
pass the filtering) or using {{.allMatch()}} or {{.noneMatch()}} instead. But
even better I think is to check the content of the list directly. I think here
it has to be exactly volume10, 12, 14, 16, 18. Otherwise it's wrong. So I think
we should just check whether it is the case here.
> Ozone: Ozone shell: Add more testing for volume shell commands
> --------------------------------------------------------------
>
> Key: HDFS-12118
> URL: https://issues.apache.org/jira/browse/HDFS-12118
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone, tools
> Affects Versions: HDFS-7240
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-12118-HDFS-7240.001.patch,
> HDFS-12118-HDFS-7240.002.patch
>
>
> Currently there are missing enough testings to cover all the ozone command.
> Now we have to test this in a manual way to see if commands run okay as
> expected. There will be lots of test cases we should add for all the volume,
> bucket and key commands. In order to easy reviewed, I'd like to separate this
> work to three subtasks. This JIRA is a good start for implementing for volume
> commands.
> Plan to add the unit test to test following command and its available options:
> * infoVolume
> * updateVolume
> * listVolume
> * createVolume
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
