[
https://issues.apache.org/jira/browse/HDFS-12118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090313#comment-16090313
]
Chen Liang commented on HDFS-12118:
-----------------------------------
+1 on v004 patch. I've committed to the feature branch, thanks [~linyiqun] for
the contribution!
One thing we should keep in mind though, is that this is based on an assumption
that the order of volumes will be maintained when listing volumes. This is
indeed the case for the current implementation. But might not be part of
listVolume semantics itself. For example, if I create volume v0, v1, v2, and do
a listVolume. Current implementation guarantees it will list in order v0, v1,
v2. But I think v0, v2, v1, or v2, v1, v0 etc can also be valid result of list
volume command. This being said, if in the future we changed the implementation
and no long keep the order when listing, we will need to change this test again.
> Ozone: Ozone shell: Add more testing for volume shell commands
> --------------------------------------------------------------
>
> Key: HDFS-12118
> URL: https://issues.apache.org/jira/browse/HDFS-12118
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone, tools
> Affects Versions: HDFS-7240
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-12118-HDFS-7240.001.patch,
> HDFS-12118-HDFS-7240.002.patch, HDFS-12118-HDFS-7240.003.patch,
> HDFS-12118-HDFS-7240.004.patch
>
>
> Currently there are missing enough testings to cover all the ozone command.
> Now we have to test this in a manual way to see if commands run okay as
> expected. There will be lots of test cases we should add for all the volume,
> bucket and key commands. In order to easy reviewed, I'd like to separate this
> work to three subtasks. This JIRA is a good start for implementing for volume
> commands.
> Plan to add the unit test to test following command and its available options:
> * infoVolume
> * updateVolume
> * listVolume
> * createVolume
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
