[ https://issues.apache.org/jira/browse/HDFS-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181634#comment-16181634 ]
Sean Mackrory commented on HDFS-7878: ------------------------------------- Looks like this patch is violating some of compatibility guarantees. The following is already annotated as Public and Stable in branch-3.0, but is removed in this patch: {code} public FileStatus(long, boolean, int, long, long, long, FsPermission, String, String, Path, Path, boolean, boolean, boolean) {code} Can we make sure a function with that prototype is added back? LocatedFileStatus is a similar situation, although it's "Evolving": {code} public LocatedFileStatus(long length, boolean isdir, int, long, long, long, FsPermission, String, String, Path, Path, boolean, boolean, boolean, BlockLocation[] locations) {code} Could someone also enlighten me as to the purpose of the commented out lines in FSProtos.proto? I thought it was odd that we were replacing "alias = 13", but I have no idea why that line is there in the first place. > API - expose an unique file identifier > -------------------------------------- > > Key: HDFS-7878 > URL: https://issues.apache.org/jira/browse/HDFS-7878 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Labels: BB2015-05-TBR > Attachments: HDFS-7878.01.patch, HDFS-7878.02.patch, > HDFS-7878.03.patch, HDFS-7878.04.patch, HDFS-7878.05.patch, > HDFS-7878.06.patch, HDFS-7878.07.patch, HDFS-7878.08.patch, > HDFS-7878.09.patch, HDFS-7878.10.patch, HDFS-7878.11.patch, > HDFS-7878.12.patch, HDFS-7878.patch > > > See HDFS-487. > Even though that is resolved as duplicate, the ID is actually not exposed by > the JIRA it supposedly duplicates. > INode ID for the file should be easy to expose; alternatively ID could be > derived from block IDs, to account for appends... > This is useful e.g. for cache key by file, to make sure cache stays correct > when file is overwritten. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org