[
https://issues.apache.org/jira/browse/HDFS-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193437#comment-16193437
]
Erik Krogen commented on HDFS-12502:
------------------------------------
Hey [~zhz], seems a good improvement. One minor nit, here I think it would be
better to use {{delta}} rather than {{1}}:
{code:title=report()}
+ if (!cmd.equals(FILES_IN_GETLISTING)) {
+ rollingWindowManager.recordMetric(currTime,
+ TopConf.ALL_CMDS, userName, 1);
{code}
Its value should only ever be 1 now but for the sake of consistency with the
{{rollingWindowManager.recordMetric(currTime, cmd, userName, delta);}} line it
seems it would be better to use {{delta}}.
Also, no new tests (modification to existing test is just to fit a new
signature), should we add one?
> nntop should support a category based on FilesInGetListingOps
> -------------------------------------------------------------
>
> Key: HDFS-12502
> URL: https://issues.apache.org/jira/browse/HDFS-12502
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: metrics
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Attachments: HDFS-12502.00.patch, HDFS-12502.01.patch,
> HDFS-12502.02.patch
>
>
> Large listing ops can oftentimes be the main contributor to NameNode
> slowness. The aggregate cost of listing ops is proportional to the
> {{FilesInGetListingOps}} rather than the number of listing ops. Therefore
> it'd be very useful for nntop to support this category.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
