[
https://issues.apache.org/jira/browse/HDFS-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218933#comment-16218933
]
Daryn Sharp commented on HDFS-12396:
------------------------------------
Didn't realize the dependency on the hdfs cipher exception. We can't move a
public stable class. I guess you could create a {{HdfsKMSUtil}} in the hdfs
project.
The method signature of {{addDelegationTokensForKeyProvider}} should accept
{{KeyProviderTokenIssuer}} instead {{Filesystem}}, which eliminates the
{{instanceof}} check.
{quote}In KMSUtil, I'm not fond of returning null when passed null ... It's the
caller's responsibility to decide to invoke a method, and the method should do
exactly what it's designed to do.
bq. Null is not an invalid input. If EZ is not enabled, this will be null.
{quote}
While null is valid _output_ from the {{getServerDefaults}} it should not be
valid _input_ to {{createKeyProviderFromUri}}. I'm just saying the uri null
check belongs in the caller so {{createKeyProviderFromUri}} is not called when
the uri is null.
> Webhdfs file system should get delegation token from kms provider.
> ------------------------------------------------------------------
>
> Key: HDFS-12396
> URL: https://issues.apache.org/jira/browse/HDFS-12396
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption, kms, webhdfs
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Attachments: HDFS-12396.001.patch, HDFS-12396.002.patch,
> HDFS-12396.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
