[ https://issues.apache.org/jira/browse/HDFS-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274933#comment-16274933 ]
Rushabh S Shah commented on HDFS-12396: --------------------------------------- Following are the failed tests from branch-2.8 patch. Don't have access to junit logs since its throwing HTTP 404 error. Ran locally and all succeeded. {noformat} Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestAbandonBlock Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.764 sec - in org.apache.hadoop.hdfs.TestAbandonBlock Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestApplyingStoragePolicy Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.399 sec - in org.apache.hadoop.hdfs.TestApplyingStoragePolicy Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestClientReportBadBlock Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.086 sec - in org.apache.hadoop.hdfs.TestClientReportBadBlock Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestDFSAddressConfig Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.253 sec - in org.apache.hadoop.hdfs.TestDFSAddressConfig Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestDFSClientExcludedNodes Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.214 sec - in org.apache.hadoop.hdfs.TestDFSClientExcludedNodes Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestDFSRollback Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.703 sec - in org.apache.hadoop.hdfs.TestDFSRollback Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestDFSUpgrade Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.918 sec - in org.apache.hadoop.hdfs.TestDFSUpgrade Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestFileAppend4 Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.252 sec - in org.apache.hadoop.hdfs.TestFileAppend4 Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestPread Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestReplaceDatanodeFailureReplication Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 62.87 sec - in org.apache.hadoop.hdfs.TestReplaceDatanodeFailureReplication Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestRollingUpgradeDowngrade Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.38 sec - in org.apache.hadoop.hdfs.TestRollingUpgradeDowngrade Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestWriteRead Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.553 sec - in org.apache.hadoop.hdfs.TestWriteRead Results : Tests run: 29, Failures: 0, Errors: 0, Skipped: 0 {noformat} Thanks [~xiaochen] for the review. bq. I'm +1 pending a minor typo: You want me to remove {{Evolving}} since {{Unstable}} is already there ? If not, can you explain what is the typo ? {quote} I feel the unit test could be more thorough: currently it tests webhdfs addDelegationTokens works. Ideally we'd want a higher level testing that the (real) tokens can be used to successfully do HDFS operations. {quote} This jira is focussing on just fetching the kms delegation token from kms. Other jiras (HDFS-12574 and HDFS-12597) are using token to decrypt edek from kms. (Currently dfs client is performing on behalf of client) I will add end to end tests in that jiras. There is one checkstyle warning in branch-2.8 version of the patch. I will fix in next revision after I receive feedback from Xiao on my prev question. > Webhdfs file system should get delegation token from kms provider. > ------------------------------------------------------------------ > > Key: HDFS-12396 > URL: https://issues.apache.org/jira/browse/HDFS-12396 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: encryption, kms, webhdfs > Reporter: Rushabh S Shah > Assignee: Rushabh S Shah > Attachments: HDFS-12396-branch-2.8.patch, HDFS-12396-branch-2.patch, > HDFS-12396.001.patch, HDFS-12396.002.patch, HDFS-12396.003.patch, > HDFS-12396.004.patch, HDFS-12396.005.patch, HDFS-12396.006.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org