[ https://issues.apache.org/jira/browse/HDFS-12759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236686#comment-16236686 ]
Hadoop QA commented on HDFS-12759: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color} | {color:red} HDFS-12759 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HDFS-12759 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12895496/HDFS-12759-HDFS-7280.002.patch | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/21934/console | | Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Ozone: web: integrate configuration reader page to the SCM/KSM web ui. > ---------------------------------------------------------------------- > > Key: HDFS-12759 > URL: https://issues.apache.org/jira/browse/HDFS-12759 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Affects Versions: HDFS-7240 > Reporter: Elek, Marton > Assignee: Elek, Marton > Labels: web-ui > Attachments: HDFS-12759-HDFS-7240.001.patch, > HDFS-12759-HDFS-7280.002.patch, after1.png, after2.png, before1.png, > before2.png, conf.png > > > In the current SCM/KSM web ui the configuration are > * hidden under the Common Tools menu > * opens a different type of web page (different menu and style). > In this patch I integrate the configuration page to the existing web ui: > From user point of view: > * Configuration page is moved to a separated main menu > * The menu of the Configuration page is the same as all the others > * Metrics are also moved to separatad pages/menus > * As the configuraiton page requires full width, all the pages use full > width layout > From technical point of view: > * To support multiple pages I enabled the angular router (which has already > been added as component) > * Not, it's suppored to create multiple pages and navigate between them, so > I also moved the metrics pages to different pages, making the main overview > page more clean. > * The layout changed to use the full width. > TESTING: > It's a client side only change. The easiest way to test is doing a full > build, start SCM/KSM and check the menu items > > * All the menu items should work > * Configuration page (from the main menu) should use the same header > * The configuration item of the Common tools menu shows the good old raw > configuration page -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org