[ https://issues.apache.org/jira/browse/HDFS-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390523#comment-16390523 ]
Íñigo Goiri commented on HDFS-13230: ------------------------------------ {quote} The cleanup method is actually moved out from CleanupTask class to the parent class, for easier testing. Otherwise, I have to somehow initialize a CleanupTask and call that method to test. {quote} That makes sense. I think this approach is good. Will you complete the TODO in the unit test? > RBF: ConnectionManager's cleanup task will compare each pool's own active > conns with its total conns > ---------------------------------------------------------------------------------------------------- > > Key: HDFS-13230 > URL: https://issues.apache.org/jira/browse/HDFS-13230 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Wei Yan > Assignee: Chao Sun > Priority: Minor > Attachments: HDFS-13230.000.patch > > > In the cleanup task: > {code:java} > long timeSinceLastActive = Time.now() - pool.getLastActiveTime(); > int total = pool.getNumConnections(); > int active = getNumActiveConnections(); > if (timeSinceLastActive > connectionCleanupPeriodMs || > {code} > the 3rd line should be pool.getNumActiveConnections() > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org