[
https://issues.apache.org/jira/browse/HDFS-13230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390559#comment-16390559
]
Wei Yan commented on HDFS-13230:
--------------------------------
In general LGTM. Some minors:
(1) We can just remove the "TODO" line, and remember to add the testcase in
HDFS-13232.
(2) In TestConnectionManager, there are two lines (44, 45) have over 80
characters.
Let's wait for the Jenkins job.
> RBF: ConnectionManager's cleanup task will compare each pool's own active
> conns with its total conns
> ----------------------------------------------------------------------------------------------------
>
> Key: HDFS-13230
> URL: https://issues.apache.org/jira/browse/HDFS-13230
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Wei Yan
> Assignee: Chao Sun
> Priority: Minor
> Attachments: HDFS-13230.000.patch
>
>
> In the cleanup task:
> {code:java}
> long timeSinceLastActive = Time.now() - pool.getLastActiveTime();
> int total = pool.getNumConnections();
> int active = getNumActiveConnections();
> if (timeSinceLastActive > connectionCleanupPeriodMs ||
> {code}
> the 3rd line should be pool.getNumActiveConnections()
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
