[ https://issues.apache.org/jira/browse/HDFS-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407883#comment-16407883 ]
genericqa commented on HDFS-13300: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 49s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 44 new or modified test files. {color} | || || || || {color:brown} HDFS-7240 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 35s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m 59s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m 57s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 32s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 7m 35s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 49s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoop-dist hadoop-ozone/integration-test {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 57s{color} | {color:red} hadoop-hdsl/common in HDFS-7240 has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 52s{color} | {color:red} hadoop-hdsl/container-service in HDFS-7240 has 66 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 52s{color} | {color:red} hadoop-ozone/common in HDFS-7240 has 2 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 37s{color} | {color:red} hadoop-ozone/objectstore-service in HDFS-7240 has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 42s{color} | {color:red} hadoop-ozone/ozone-manager in HDFS-7240 has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 15s{color} | {color:green} HDFS-7240 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 15s{color} | {color:red} client in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 15m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 6m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 0s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 32s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 27s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoop-dist hadoop-ozone/integration-test {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 52s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 48s{color} | {color:green} client in the patch passed. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 6s{color} | {color:red} hadoop-hdsl/common generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 54s{color} | {color:green} hadoop-hdsl/container-service generated 0 new + 62 unchanged - 4 fixed = 62 total (was 66) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 50s{color} | {color:red} hadoop-hdsl/server-scm generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 42s{color} | {color:green} tools in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 54s{color} | {color:green} common in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 46s{color} | {color:green} hadoop-ozone/objectstore-service generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 46s{color} | {color:green} ozone-manager in the patch passed. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 45s{color} | {color:red} hadoop-ozone/tools generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 24s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 40s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 24s{color} | {color:green} hadoop-dist in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 26s{color} | {color:green} client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 18s{color} | {color:green} common in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 34s{color} | {color:red} container-service in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 46s{color} | {color:red} server-scm in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 25s{color} | {color:green} tools in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 35s{color} | {color:green} common in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 25s{color} | {color:red} integration-test in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 30s{color} | {color:green} objectstore-service in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 35s{color} | {color:green} ozone-manager in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s{color} | {color:green} tools in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 38s{color} | {color:red} The patch generated 2201 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}149m 35s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-hdsl/common | | | org.apache.hadoop.hdsl.protocol.DatanodeDetails defines compareTo(DatanodeDetails) and uses Object.equals() At DatanodeDetails.java:Object.equals() At DatanodeDetails.java:[line 296] | | FindBugs | module:hadoop-hdsl/server-scm | | | java.util.UUID is incompatible with expected argument type org.apache.hadoop.hdsl.protocol.DatanodeDetails in org.apache.hadoop.ozone.scm.node.SCMNodeManager.moveStaleNodeToDead(Map$Entry) At SCMNodeManager.java:argument type org.apache.hadoop.hdsl.protocol.DatanodeDetails in org.apache.hadoop.ozone.scm.node.SCMNodeManager.moveStaleNodeToDead(Map$Entry) At SCMNodeManager.java:[line 589] | | | java.util.UUID is incompatible with expected argument type org.apache.hadoop.hdsl.protocol.DatanodeDetails in org.apache.hadoop.ozone.scm.node.SCMNodeManager.moveStaleNodeToDead(Map$Entry) At SCMNodeManager.java:argument type org.apache.hadoop.hdsl.protocol.DatanodeDetails in org.apache.hadoop.ozone.scm.node.SCMNodeManager.moveStaleNodeToDead(Map$Entry) At SCMNodeManager.java:[line 587] | | | Possible null pointer dereference of datanodeDetails in org.apache.hadoop.ozone.scm.node.SCMNodeManager.sendHeartbeat(HdslProtos$DatanodeDetailsProto, StorageContainerDatanodeProtocolProtos$SCMNodeReport, StorageContainerDatanodeProtocolProtos$ReportState) Dereferenced at SCMNodeManager.java:datanodeDetails in org.apache.hadoop.ozone.scm.node.SCMNodeManager.sendHeartbeat(HdslProtos$DatanodeDetailsProto, StorageContainerDatanodeProtocolProtos$SCMNodeReport, StorageContainerDatanodeProtocolProtos$ReportState) Dereferenced at SCMNodeManager.java:[line 847] | | FindBugs | module:hadoop-ozone/tools | | | Format string "%d" needs argument 7 but only 6 are provided in org.apache.hadoop.ozone.scm.cli.SQLCLI.insertContainerDB(Connection, String, HdslProtos$Pipeline, Set) At SQLCLI.java:7 but only 6 are provided in org.apache.hadoop.ozone.scm.cli.SQLCLI.insertContainerDB(Connection, String, HdslProtos$Pipeline, Set) At SQLCLI.java:[line 548] | | | Format string "%d" needs argument 7 but only 6 are provided in org.apache.hadoop.ozone.scm.cli.SQLCLI.insertNodePoolDB(Connection, String, DatanodeDetails) At SQLCLI.java:7 but only 6 are provided in org.apache.hadoop.ozone.scm.cli.SQLCLI.insertNodePoolDB(Connection, String, DatanodeDetails) At SQLCLI.java:[line 651] | | Failed junit tests | hadoop.ozone.scm.container.closer.TestContainerCloser | | | hadoop.ozone.container.replication.TestContainerSupervisor | | | hadoop.ozone.scm.node.TestSCMNodePoolManager | | | hadoop.ozone.scm.TestStorageContainerManagerHttpServer | | | hadoop.ozone.scm.node.TestNodeManager | | | hadoop.ozone.scm.block.TestDeletedBlockLog | | | hadoop.ozone.scm.TestSCMMetrics | | | hadoop.ozone.scm.TestContainerSmallFile | | | hadoop.ozone.ozShell.TestOzoneShell | | | hadoop.ozone.scm.TestSCMMXBean | | | hadoop.ozone.ksm.TestKsmBlockVersioning | | | hadoop.ozone.web.client.TestKeys | | | hadoop.ozone.web.client.TestBuckets | | | hadoop.ozone.scm.TestAllocateContainer | | | hadoop.ozone.ksm.TestKSMMetrcis | | | hadoop.ozone.web.TestOzoneWebAccess | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler | | | hadoop.ozone.scm.TestXceiverClientMetrics | | | hadoop.ozone.ksm.TestContainerReportWithKeys | | | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.scm.container.TestContainerStateManager | | | hadoop.ozone.scm.TestSCMCli | | | hadoop.ozone.container.ozoneimpl.TestOzoneContainer | | | hadoop.ozone.web.client.TestVolume | | | hadoop.ozone.ksm.TestKSMSQLCli | | | hadoop.ozone.scm.TestContainerSQLCli | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.web.TestOzoneRestWithMiniCluster | | | hadoop.ozone.tools.TestFreon | | | hadoop.ozone.client.rest.TestOzoneRestClient | | | hadoop.ozone.web.TestDistributedOzoneVolumes | | | hadoop.ozone.ksm.TestKeySpaceManagerRestInterface | | | hadoop.ozone.web.client.TestOzoneClient | | | hadoop.ozone.web.client.TestKeysRatis | | | hadoop.ozone.tools.TestDataValidate | | | hadoop.ozone.scm.node.TestQueryNode | | | hadoop.ozone.ksm.TestKeySpaceManager | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.ozone.scm.TestXceiverClientManager | | | hadoop.ozone.TestContainerOperations | | | hadoop.ozone.ksm.TestMultipleContainerReadWrite | | | hadoop.ozone.web.TestLocalOzoneVolumes | | | hadoop.ozone.container.metrics.TestContainerMetrics | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:215a942 | | JIRA Issue | HDFS-13300 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12915454/HDFS-13300-HDFS-7240.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient shellcheck shelldocs findbugs checkstyle cc xml | | uname | Linux ce2bb4e047ff 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HDFS-7240 / 7ace05b | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | shellcheck | v0.4.6 | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/branch-findbugs-hadoop-hdsl_common-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/branch-findbugs-hadoop-hdsl_container-service-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/branch-findbugs-hadoop-ozone_common-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/branch-findbugs-hadoop-ozone_objectstore-service-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager-warnings.html | | mvninstall | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/patch-mvninstall-hadoop-hdsl_client.txt | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/new-findbugs-hadoop-hdsl_common.html | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/new-findbugs-hadoop-hdsl_server-scm.html | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/new-findbugs-hadoop-ozone_tools.html | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/patch-unit-hadoop-hdsl_container-service.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/patch-unit-hadoop-hdsl_server-scm.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 890 (vs. ulimit of 10000) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-dist hadoop-hdsl/client hadoop-hdsl/common hadoop-hdsl/container-service hadoop-hdsl/server-scm hadoop-hdsl/tools hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/objectstore-service hadoop-ozone/ozone-manager hadoop-ozone/tools U: . | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/23606/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Ozone: Remove DatanodeID dependency from HDSL and Ozone > -------------------------------------------------------- > > Key: HDFS-13300 > URL: https://issues.apache.org/jira/browse/HDFS-13300 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Reporter: Nanda kumar > Assignee: Nanda kumar > Priority: Major > Attachments: HDFS-13300-HDFS-7240.000.patch, > HDFS-13300-HDFS-7240.001.patch > > > DatanodeID has been modified to add HDSL/Ozone related information > previously. This jira is to remove DatanodeID dependency from HDSL/Ozone to > make it truly pluggable without having the need to modify DatanodeID. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org