[ https://issues.apache.org/jira/browse/HDFS-13300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408434#comment-16408434 ]
Nanda kumar commented on HDFS-13300: ------------------------------------ Thanks for the review, [~elek]. {quote}I am not sure if we need infoPort. As I remember it is used for DatanodeHttp server which is not required for hdsl/ozone any more. {quote} We actually don't need this port, but to remove this we need to modify KSM and OzoneClient code (because of ServiceDiscovery API). Created HDFS-13324 to track this. {quote}I am happy with this change but please keep the two plugin names consistent. {quote} Sure, created HDFS-13325 to track this. {quote}I can't see how the race condition between hdsl/object store services(=plugins) are handled. {quote} There is no race condition here. Plugins are loaded in the same order as they are specified in the property, so HdslDatanodeService will be loaded first; this will create DatanodeDetails instance. When ObjectStoreRestPlugin is loaded, it will get DatanodeDetails instance from HdslDatanodeService and update OzoneRestPort. {{SCMNodeManager.hadleHeartbeat}} doesn't have any idea about the ports used by datanode (HdslDatanodeService & ObjectStoreRestPlugin). {quote}I think this is the reason behind the failing REST related unit tests (didn't check, just my guess). {quote} The reason behind test failures is because of a bug in {{MiniOzoneClassicCluster}} change. It has been fixed in patch v002 Change: MiniOzoneClassicCluster - line:124 : It was {{conf.setStrings...}} which should be {{dnConf.setStrings...}} {quote}I am not sure if we need to persist the DatanodeDetails. I think it's enogh to persiste the UUID. {quote} True, we just need the UUID. The reason for storing DatanodeDetails is because we got protobuf of DatanodeDetails which makes it easy to persist :) {quote}If I understood well, now it is true, as all the ports are updated after reading the datanode descriptor from the file. {quote} Exactly. {quote}This is a smal one, but some javadoc still use the "Datanode ID" expression which could be confusing {quote} Thanks for the catch, fixed it in patch v002 > Ozone: Remove DatanodeID dependency from HDSL and Ozone > -------------------------------------------------------- > > Key: HDFS-13300 > URL: https://issues.apache.org/jira/browse/HDFS-13300 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Reporter: Nanda kumar > Assignee: Nanda kumar > Priority: Major > Attachments: HDFS-13300-HDFS-7240.000.patch, > HDFS-13300-HDFS-7240.001.patch, HDFS-13300-HDFS-7240.002.patch > > > DatanodeID has been modified to add HDSL/Ozone related information > previously. This jira is to remove DatanodeID dependency from HDSL/Ozone to > make it truly pluggable without having the need to modify DatanodeID. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org