[ 
https://issues.apache.org/jira/browse/HDFS-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414179#comment-16414179
 ] 

Mingliang Liu commented on HDFS-8979:
-------------------------------------

The patch did not break HDFS-13330, if you understand the problem of that retry 
logic correctly. If you are not able to understand the patch, why not read the 
link Chris shared?

The two breaks you were mentioning, one was for unit test in branch-2 only. I 
joined the discussion and reviewed the patch to fix. The other one was a major 
bug. I attached a fix for that after Kihwal reported. If you find new bugs, I'm 
always willing to help here. You can not revert a large commit because you are 
worried about the possibility of bugs. If you can instead file a real bug and 
attach a fix, I would then appreciate your effort.

> Clean up checkstyle warnings in hadoop-hdfs-client module
> ---------------------------------------------------------
>
>                 Key: HDFS-8979
>                 URL: https://issues.apache.org/jira/browse/HDFS-8979
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>            Priority: Major
>             Fix For: 2.8.0, 3.0.0-alpha1
>
>         Attachments: HDFS-8979.000.patch, HDFS-8979.001.patch, 
> HDFS-8979.002.patch
>
>
> This jira tracks the effort of cleaning up checkstyle warnings in 
> {{hadoop-hdfs-client}} module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to