[ https://issues.apache.org/jira/browse/HDFS-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416021#comment-16416021 ]
Mingliang Liu commented on HDFS-8979: ------------------------------------- I totally agree addressing checkstyle issues should be more careful especially for a large patch. The assumption was that, code was bug-free and checkstyle issues were minor/easy to fix. That is not always true. I should have paid more attention to the context and code intention. I would not prefer bulk fixes like this if I do it again. I'd also attach branch-specific patch for static analysis reports like this. Anyway I'm glad we find HDFS-13330 bug regardless of this change. > Clean up checkstyle warnings in hadoop-hdfs-client module > --------------------------------------------------------- > > Key: HDFS-8979 > URL: https://issues.apache.org/jira/browse/HDFS-8979 > Project: Hadoop HDFS > Issue Type: Task > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Priority: Major > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: HDFS-8979.000.patch, HDFS-8979.001.patch, > HDFS-8979.002.patch > > > This jira tracks the effort of cleaning up checkstyle warnings in > {{hadoop-hdfs-client}} module. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org