[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433678#comment-16433678 ]
Tao Jie commented on HDFS-13418: -------------------------------- Thank you [~linyiqun] for your comments. For the UT, I think we need one additional case, which is what I actually need: Switch {{dfs.use.dfs.network.topology}} to true, then set the value of {{dfs.net.topology.impl}} to class that extends {{DFSNetworkTopology}}. Actually I am trying to add a new NetworkTopology and expect it to go well with the current {{DFSNetworkTopology}}. So I need this test case to ensure it does work. I will update the patch as your suggestion soon. > NetworkTopology should be configurable when enable DFSNetworkTopology > ---------------------------------------------------------------------- > > Key: HDFS-13418 > URL: https://issues.apache.org/jira/browse/HDFS-13418 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 3.0.1 > Reporter: Tao Jie > Assignee: Tao Jie > Priority: Major > Attachments: HDFS-13418.001.patch, HDFS-13418.002.patch > > > In HDFS-11530 we introduce DFSNetworkTopology and in HDFS-11998 we set > DFSNetworkTopology as the default implementation. > We still have {{net.topology.impl=org.apache.hadoop.net.NetworkTopology}} in > core-site.default. Actually this property does not effect once > {{dfs.use.dfs.network.topology}} is true. > in {{DatanodeManager}},networkTopology is initialized as > {code} > if (useDfsNetworkTopology) { > networktopology = DFSNetworkTopology.getInstance(conf); > } else { > networktopology = NetworkTopology.getInstance(conf); > } > {code} > I think we should still make the NetworkTopology configurable rather than > hard code the implementation since we may need another NetworkTopology impl. > I am not sure if there is other consideration. Any thought? [~vagarychen] > [~linyiqun] -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org