[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437129#comment-16437129 ]
Hudson commented on HDFS-13418: ------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13992 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13992/]) HDFS-13418. NetworkTopology should be configurable when enable (yqlin: rev 0725953efec89b35b7586b846abb01f7c5963b37) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestDatanodeManager.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/net/DFSNetworkTopology.java > NetworkTopology should be configurable when enable DFSNetworkTopology > ---------------------------------------------------------------------- > > Key: HDFS-13418 > URL: https://issues.apache.org/jira/browse/HDFS-13418 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 3.0.1 > Reporter: Tao Jie > Assignee: Tao Jie > Priority: Major > Fix For: 2.10.0, 3.2.0, 3.1.1 > > Attachments: HDFS-13418-branch2.001.patch, HDFS-13418.001.patch, > HDFS-13418.002.patch, HDFS-13418.003.patch, HDFS-13418.004.patch > > > In HDFS-11530 we introduce DFSNetworkTopology and in HDFS-11998 we set > DFSNetworkTopology as the default implementation. > We still have {{net.topology.impl=org.apache.hadoop.net.NetworkTopology}} in > core-site.default. Actually this property does not effect once > {{dfs.use.dfs.network.topology}} is true. > in {{DatanodeManager}},networkTopology is initialized as > {code} > if (useDfsNetworkTopology) { > networktopology = DFSNetworkTopology.getInstance(conf); > } else { > networktopology = NetworkTopology.getInstance(conf); > } > {code} > I think we should still make the NetworkTopology configurable rather than > hard code the implementation since we may need another NetworkTopology impl. > I am not sure if there is other consideration. Any thought? [~vagarychen] > [~linyiqun] -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org