[ 
https://issues.apache.org/jira/browse/HDFS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067873#comment-13067873
 ] 

Aaron T. Myers commented on HDFS-1620:
--------------------------------------

Hey Harsh, we're unfortunately inconsistent throughout the projects in our 
camel casing of initialisms (I'm guilty of this myself) but I think we should 
tend toward treating an initialism as though it were a normal word when it 
comes to capitalization. So rather than {{DFSConstants}}, I think it should be 
{{DfsConstants}}.

Otherwise the patch looks good. I'll commit it pending that concern being 
addressed (either by updating the patch or by telling me I'm being pedantic.) :)

> FSConstants vs FsConstants 
> ---------------------------
>
>                 Key: HDFS-1620
>                 URL: https://issues.apache.org/jira/browse/HDFS-1620
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1620.r1.diff, HDFS-1620.r2.diff
>
>
> We have {{org.apache.hadoop.hdfs.protocol.*FSConstants*}} and 
> {{org.apache.hadoop.fs.*FsConstants*}}.  Elegant or confused?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to