[ 
https://issues.apache.org/jira/browse/HDFS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068038#comment-13068038
 ] 

Aaron T. Myers commented on HDFS-1620:
--------------------------------------

bq. Ideally, the class protocol.FSConstants ought to be protocol.HdfsConstants 
and the class server.HdfsConstants can be server.HdfsServerConstants, to 
preserve their meaning in the classnames itself. The contents look like they 
should still be kept separate, and with these names I think they'd make more 
sense.

+1, I think this plan makes a lot of sense. You've clearly thought about this 
quite a bit.

> FSConstants vs FsConstants 
> ---------------------------
>
>                 Key: HDFS-1620
>                 URL: https://issues.apache.org/jira/browse/HDFS-1620
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1620.r1.diff, HDFS-1620.r2.diff, HDFS-1620.r3.diff
>
>
> We have {{org.apache.hadoop.hdfs.protocol.*FSConstants*}} and 
> {{org.apache.hadoop.fs.*FsConstants*}}.  Elegant or confused?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to