[ https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506284#comment-16506284 ]
Erik Krogen commented on HDFS-12976: ------------------------------------ Thanks for taking this on [~csun]! I have two overall comments. Why is the {{currentIndex}} for {{observerProxies}} a {{ThreadLocal}}? If an observer is throwing exceptions which should be retried on a different observer, the issue should affect all of the threads, so we should move all of them to a new observer, right? I'm worried about keeping the list of observer proxies completely separate from the list of active/standby observers. This won't support an observer<->standby transitions. That's probably fine for an initial version but I want to make sure we are at least planning for the future - I don't really see how this design can be evolved to accommodate transitions. Do you have any ideas? > Introduce ObserverReadProxyProvider > ----------------------------------- > > Key: HDFS-12976 > URL: https://issues.apache.org/jira/browse/HDFS-12976 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Reporter: Konstantin Shvachko > Assignee: Chao Sun > Priority: Major > Attachments: HDFS-12976-HDFS-12943.000.patch, HDFS-12976.WIP.patch > > > {{StandbyReadProxyProvider}} should implement {{FailoverProxyProvider}} > interface and be able to submit read requests to ANN and SBN(s). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org