[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507165#comment-16507165
]
Konstantin Shvachko commented on HDFS-12976:
--------------------------------------------
[~csun] the patch looks good to me except syntactical things:
# The log messages mentioned above, if they are still needed.
# And References to generic types should be parameterized: like
{code}
public FailoverProxyProvider<T> getProxyProvider() {
ProxyInfo<T> getLastProxy() {
{code}
# I prefer if we adopt term {{ObserverNode}}, rather than {{ObserverNameNode}}.
So it will be {{TestObserverNode}}. If people are OK with that.
# Some long lines
I think thread-local index is fine. The same client going to different
Observers may increase the throughput of the client overall. If we decide all
threads should use the same Observer, we can modify this later.
Also Erik's and Chen's suggestions can be handled in separate jira(s).
> Introduce ObserverReadProxyProvider
> -----------------------------------
>
> Key: HDFS-12976
> URL: https://issues.apache.org/jira/browse/HDFS-12976
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Konstantin Shvachko
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-12976-HDFS-12943.000.patch, HDFS-12976.WIP.patch
>
>
> {{StandbyReadProxyProvider}} should implement {{FailoverProxyProvider}}
> interface and be able to submit read requests to ANN and SBN(s).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
