[
https://issues.apache.org/jira/browse/HDDS-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592214#comment-16592214
]
Xiaoyu Yao commented on HDDS-359:
---------------------------------
{quote}{quote}Line 141: this assumes all tables have the same column family
option. Is it possible to have per table column family option
{quote}
We already do that. When the user add a table, they can call addTable(string)
or addTable(string, options). If the first addTable is used, we iterate thru
the string table and add the default option. If the user had called
addTable(string, option) then the user specified option would be used.
{quote}
I think the confusion is that DBStoreBuilder#addTable() allows add per table
column family option. But the caller processTableNames() only pass the same one
from dbProfile.getColumnFamilyOptions() in line 141 based on SSD/DISK.
For example, if we have two tables: one for normal key and the other for open
key both take the SSD profile but open key table may want some different column
family settings.
{quote}{quote}Can we abstract the table config otherwise we can use
ColumnFamilyOptions directly
{quote}
Sorry, I am not sure I understand this comment clearly. Could you please
explain it to me once more ?
{quote}
I mean the TableConfig class is almost the same as ColumnFamilyOption. We could
potentially use it directly.
{quote}It is hard to merge these since it because harder to define what the
final config will look like.
{quote}
Good point. Let's revisit this later if things change.
> RocksDB Profiles support
> ------------------------
>
> Key: HDDS-359
> URL: https://issues.apache.org/jira/browse/HDDS-359
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-359.001.patch, HDDS-359.002.patch,
> HDDS-359.003.patch, HDDS-359.004.patch
>
>
> This allows us to tune the OM/SCM DB for different machine configurations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
