[
https://issues.apache.org/jira/browse/HDDS-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593392#comment-16593392
]
Elek, Marton commented on HDDS-359:
-----------------------------------
Thanks Anu the patch. I like this approach especially the flexibility in the
configuration method. As you wrote:
{quote}
Here is what we are doing, if there is a name.db.ini in the config directory,
we will use those params for the RocksDB. Otherwise, we will use the profile
key if specified, if there is nothing specified we will use the default
profile. The return of null makes it easy for us to know that we need to get a
profile from the secondary sources.
{quote}
I have two minor comments (non of them are blockers):
1. Would be great to get some log output about initializing the
table/columnfamiliy with a specific file/profile. Users may not familiar with
this configuration but checking the log it could be a warning if I have only
spinning disk but the log contains something about SSD. Also would be easier to
check if a custom db file is picked. I would be happy even with an INFO level
line.
2. I would use HddsConfigKeys instead of OzoneConfigKeys. The functionality is
part of the core hdds and long term we need to separated the ozone specific and
hdds specific configuration (not a blocker as we have a lot of other
configurations which should be moved to the HddsConfigKeys).
But non of these are blockers, both of them could be improved later. I am +1
even without these...
> RocksDB Profiles support
> ------------------------
>
> Key: HDDS-359
> URL: https://issues.apache.org/jira/browse/HDDS-359
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-359.001.patch, HDDS-359.002.patch,
> HDDS-359.003.patch, HDDS-359.004.patch
>
>
> This allows us to tune the OM/SCM DB for different machine configurations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
