[
https://issues.apache.org/jira/browse/HDFS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087850#comment-13087850
]
Hadoop QA commented on HDFS-362:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490959/HDFS-362.2.patch
against trunk revision 1159004.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat
org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
org.apache.hadoop.hdfs.TestHDFSServerPorts
org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
-1 contrib tests. The patch failed contrib unit tests.
-1 system test framework. The patch failed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1126//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1126//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1126//console
This message is automatically generated.
> FSEditLog should not writes long and short as UTF8 and should not use
> ArrayWritable for writing non-array items
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-362
> URL: https://issues.apache.org/jira/browse/HDFS-362
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-362.1.patch, HDFS-362.2.patch, HDFS-362.patch
>
>
> In FSEditLog,
> - long and short are first converted to String and are further converted to
> UTF8
> - For some non-array items, it first create an ArrayWritable object to hold
> all the items and then writes the ArrayWritable object.
> These result creating many intermediate objects which affects Namenode CPU
> performance and Namenode restart.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
