[
https://issues.apache.org/jira/browse/HDFS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090374#comment-13090374
]
Uma Maheswara Rao G commented on HDFS-362:
------------------------------------------
Hi Todd,
Thanks a lot for taking a look on this patch!
{quote}
Rather than comparing the logVersion variable against the numeric -39 version,
check out LayoutVersion.supports(...) – makes the code easier to read
{quote}
Nice suggestion. Addressed in this patch.
Thanks
Uma
> FSEditLog should not writes long and short as UTF8 and should not use
> ArrayWritable for writing non-array items
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-362
> URL: https://issues.apache.org/jira/browse/HDFS-362
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-362.1.patch, HDFS-362.2.patch, HDFS-362.2b.patch,
> HDFS-362.2c.patch, HDFS-362.patch
>
>
> In FSEditLog,
> - long and short are first converted to String and are further converted to
> UTF8
> - For some non-array items, it first create an ArrayWritable object to hold
> all the items and then writes the ArrayWritable object.
> These result creating many intermediate objects which affects Namenode CPU
> performance and Namenode restart.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
