[ 
https://issues.apache.org/jira/browse/HDFS-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092374#comment-13092374
 ] 

Hadoop QA commented on HDFS-962:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12491974/HDFS-962.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these unit tests:

                  
org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1171//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1171//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1171//console

This message is automatically generated.

> Make DFSOutputStream MAX_PACKETS configurable
> ---------------------------------------------
>
>                 Key: HDFS-962
>                 URL: https://issues.apache.org/jira/browse/HDFS-962
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs client
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Priority: Minor
>         Attachments: HDFS-962.patch
>
>
> HDFS-959 suggests that the MAX_PACKETS variable (which determines how many 
> outstanding data packets the DFSOutputStream will permit) may have an impact 
> on performance. If so, we should make it configurable to trade off between 
> memory and performance. I think it ought to be a secret/undocumented config 
> for now - this will make it easier to benchmark without confusing users.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to