[ https://issues.apache.org/jira/browse/HDFS-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093504#comment-13093504 ]
Tsz Wo (Nicholas), SZE commented on HDFS-962: --------------------------------------------- Hi Justin, Thanks for working on this. Some comments on the patch: - change dfsMaxPackets to private and non-static. - define constants for dfs.max.packets in DFSConfigKeys > Make DFSOutputStream MAX_PACKETS configurable > --------------------------------------------- > > Key: HDFS-962 > URL: https://issues.apache.org/jira/browse/HDFS-962 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs client > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Justin Joseph > Priority: Minor > Attachments: HDFS-962.patch > > > HDFS-959 suggests that the MAX_PACKETS variable (which determines how many > outstanding data packets the DFSOutputStream will permit) may have an impact > on performance. If so, we should make it configurable to trade off between > memory and performance. I think it ought to be a secret/undocumented config > for now - this will make it easier to benchmark without confusing users. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira