[ 
https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677437#comment-16677437
 ] 

Chen Liang commented on HDFS-14035:
-----------------------------------

Post v010 patch to address [~csun]'s comments.
bq. 1. RouterRpcClient#getHAServiceState  and 
RouterRpcService#getHAServiceState...
Good catch. I agree that the patch may not be doing the right thing. But it 
looked that adding unit test for this seems tricky because we need a federation 
+ HA setup. Also since it is known that Observer read is not currently 
supporting federation, I prefer to postpone addressing this. For now I just 
made it an unsupported operation in RouterClientProtocol

bq. 3. In ClientProtocolAnswer, can we use
An issue is that ClientProtocolAnswer also includes several other calls. 
Changing it to HAServiceState is to indicate that all the calls are returning 
HAServiceState type, only that the other calls always returns null, the syntax 
still makes little sense to me.

> NN status discovery does not leverage delegation token
> ------------------------------------------------------
>
>                 Key: HDFS-14035
>                 URL: https://issues.apache.org/jira/browse/HDFS-14035
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Major
>         Attachments: HDFS-14035-HDFS-12943.001.patch, 
> HDFS-14035-HDFS-12943.002.patch, HDFS-14035-HDFS-12943.003.patch, 
> HDFS-14035-HDFS-12943.004.patch, HDFS-14035-HDFS-12943.005.patch, 
> HDFS-14035-HDFS-12943.006.patch, HDFS-14035-HDFS-12943.007.patch, 
> HDFS-14035-HDFS-12943.008.patch, HDFS-14035-HDFS-12943.009.patch, 
> HDFS-14035-HDFS-12943.010.patch
>
>
> Currently ObserverReadProxyProvider uses 
> {{HAServiceProtocol#getServiceStatus}} to get the status of each NN. However 
> {{HAServiceProtocol}} does not leverage delegation token. So when running an 
> application on YARN and when YARN node manager makes this call 
> getServiceStatus, token authentication will fail, causing the application to 
> fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to