[
https://issues.apache.org/jira/browse/HDDS-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710667#comment-16710667
]
Bharat Viswanadham commented on HDDS-864:
-----------------------------------------
Thank You [~elek]
for the updated patch.
Patch almost LGTM.
Few comments I have are:
#
VolumeManagerImpl.java:
Line 246: VolumeInfo newVolumeInfo = newVolumeArgs.getProtobuf(); can be
removed, as it is not being used.
Line 247: metadataManager.getVolumeTable().put(dbVolumeKey, volumeArgs);
Here it should be updated as below
metadataManager.getVolumeTable().put(dbVolumeKey, newVolumeArgs);
#
In createVolume(), we are writing args in to volumeTable
metadataManager.getVolumeTable().putWithBatch(batch,
dbVolumeKey, args);
But we are not setting creation time, as the original args will not have
creation time set. That is the reason for some of tests failure in
TestOzoneRpcClient
#
For OmKeyInfoCodec and other in toPersistedFormat(), As discussed offline, we
can have Precondition check for null, as technically we should not get Null
over there (This will also help in identifying bugs if we are passing null
values). Have a look into it we can add here.
#
I think 1, 2 and if it is fixed some of the Unit tests will be fixed. Have a
look into other tests, if those are real issues.
> Use strongly typed codec implementations for the tables of the
> OmMetadataManager
> --------------------------------------------------------------------------------
>
> Key: HDDS-864
> URL: https://issues.apache.org/jira/browse/HDDS-864
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: OM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Attachments: HDDS-864.001.patch, HDDS-864.002.patch,
> HDDS-864.003.patch
>
>
> HDDS-748 provides a way to use higher level, strongly typed metadata Tables,
> such as Table<String,OmKeyInfo> instead of Table<byte[],byte[]>
> HDDS-748 provides the new TypedTable in this jira I would fix the
> OmMetadataManagerImpl to use the type-safe tables instead of the raw ones.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
