[ https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753757#comment-16753757 ]
Sammi Chen commented on HDDS-699: --------------------------------- Hi [~linyiqun] thanks for the review effort. {quote}Can we address this corner case in test {{testAddRemove}}? Also a similar case, we can add a node without parent existed, and to see if the parent nodes is created as we expected {quote} The first is covered in {{testAddRemove}}, ROOT has level "1", level "2" means ROOT's children. A new check will be added for the second suggestion. {code:java} // no inner nodes assertEquals(0, cluster.getNumOfNodes(2)); {code} {quote}Can we rename NetConf, NetUtils to a more readable name TopologyConf, TopologyUtils? Here Net will be understood as the meaning of Network not NetworkTopology, {quote} Make sense. The rest will be addressed in the new patch. > Detect Ozone Network topology > ----------------------------- > > Key: HDDS-699 > URL: https://issues.apache.org/jira/browse/HDDS-699 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Xiaoyu Yao > Assignee: Sammi Chen > Priority: Major > Attachments: HDDS-699.00.patch, HDDS-699.01.patch > > > Traditionally this has been implemented in Hadoop via script or customizable > java class. One thing we want to add here is the flexible multi-level support > instead of fixed levels like DC/Rack/NG/Node. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org