[ https://issues.apache.org/jira/browse/HDFS-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775470#comment-16775470 ]
Chao Sun commented on HDFS-14130: --------------------------------- Thanks [~shv]. I'm slightly more in favor of the System.in approach because it's more realistic - curious why it failed but the one in TestDFSHAAdmin didn't. The latest patch looks better since it reset the {{System.in}} after finish. The fix itself looks good to me. One minor nit: change {{testverifyObserverState}} to {{testVerifyObserverState}}. > Make ZKFC ObserverNode aware > ---------------------------- > > Key: HDFS-14130 > URL: https://issues.apache.org/jira/browse/HDFS-14130 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha > Affects Versions: HDFS-12943 > Reporter: Konstantin Shvachko > Assignee: xiangheng > Priority: Major > Attachments: HDFS-14130-HDFS-12943.001.patch, > HDFS-14130-HDFS-12943.003.patch, HDFS-14130-HDFS-12943.004.patch, > HDFS-14130-HDFS-12943.005.patch, HDFS-14130-HDFS-12943.006.patch, > HDFS-14130-HDFS-12943.007.patch, HDFS-14130.008.patch, HDFS-14130.009.patch, > HDFS-14130.010.patch > > > Need to fix automatic failover with ZKFC. Currently it does not know about > ObserverNodes trying to convert them to SBNs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org