[
https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815918#comment-16815918
]
Yiqun Lin edited comment on HDFS-14406 at 4/12/19 3:03 AM:
-----------------------------------------------------------
This idea makes sense to me, although here the process time contains the
lock-waiting time not pure rpc process time. But in some scenarios, people also
want to know this time in metrics. We make this optional now, so it looks fine.
Some review comments:
*RpcUserMetrics*
1.We should unregister the MetricsRegistry instance when shutdown
{code}
/**
* Shutdown the instrumentation for the process.
*/
public void shutdown() {
DefaultMetricsSystem.instance().unregisterSource(name);
}
{code}
2. Can we complete the java doc for the function {{addDeferredProcessingTime}}?
*CommonConfigurationKeysPublic*
Document the new config {{ipc.server.user.metrics}} in core-default.xml.
*Unit test*
I don't see the test for getting user RPC metric via JMX. Can you add related
test for this?
was (Author: linyiqun):
This idea makes sense to me, although here the process time contains the
lock-waiting time not pure rpc process time. But in some scenarios, people also
want to know this time in metrics. We make this optional now, so it looks fine.
Some review comments:
* RpcUserMetrics*
1.We should unregister the MetricsRegistry instance when shutdown
{code}
/**
* Shutdown the instrumentation for the process.
*/
public void shutdown() {
DefaultMetricsSystem.instance().unregisterSource(name);
}
{code}
2. Can we complete the java doc for the function {{addDeferredProcessingTime}}?
*CommonConfigurationKeysPublic*
Document the new config {{ipc.server.user.metrics}} in core-default.xml.
I don't see the test for getting user RPC metric via JMX. Can you add related
test for this?
> Add per user RPC Processing time
> --------------------------------
>
> Key: HDFS-14406
> URL: https://issues.apache.org/jira/browse/HDFS-14406
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Xue Liu
> Assignee: Xue Liu
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: HDFS-14406.001.patch, HDFS-14406.002.patch,
> HDFS-14406.003.patch
>
>
> For a shared cluster we would want to separate users' resources, as well as
> having our metrics reflecting on the usage, latency, etc, for each user.
> This JIRA aims to add per user RPC processing time metrics and expose it via
> JMX.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
